-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): add additive behavior #94
base: master
Are you sure you want to change the base?
Conversation
This commit adds additive behavior, mimicking the behavior when holding the Shift key. Updated app to be able to select addictive behavior. Updated Cypress tests. Updated documentation.
This commit adds additive behavior, mimicking the behavior when holding the Shift key. Fixed Additive implementation; Updated tests and documentation;
@d3lm, I couldn't implement the unselect items when dragging through them, they started flickering. Cheers |
Code cleaning.
Hey @vascocc, sorry for the late response, but do you still want to work on this PR? I am doing a bit of maintenance and closing stale PR's / issues. I still think this feature is cool, so maybe we can get it over the finish line? |
93f1299
to
1afd221
Compare
Hi guys, any idea of when this feature will be merged ? Is takes a very long time for conflict on README file... |
@s-f-a-g FWIW, it's not just the readme. Check our PR conversation. With the current state of this PR it's not compatible with all existing features and unselecting doesn't work. |
f737d7d
to
1fd7215
Compare
hey Is there anything I could do to help and merge this feature? |
Not working on this anymore. |
yes I'd be happy to help if you could point me the missing pieces |
This commit adds additive behavior, mimicking the behavior when holding the Shift key.
Updated app to be able to select addictive behavior.
Updated Cypress tests.
Updated documentation.